Re: [Duplicity-talk] Odd backtrace on 0.5.16

[Kenneth Loafman]

Michael Terry wrote:
> After doing a collection-status (on an empty directory) with 0.5.16, I
> get the following exception (after it seemingly finishes the
> collection-status):
> 
> Traceback (most recent call last):
>   File "./duplicity/duplicity-0.5.16/usr/local/bin/duplicity", line
> 828, in <module>
>     with_tempdir(main)
>   File "./duplicity/duplicity-0.5.16/usr/local/bin/duplicity", line
> 821, in with_tempdir
>     fn()
>   File "./duplicity/duplicity-0.5.16/usr/local/bin/duplicity", line 795, in 
> main
>     full_backup(col_stats)
>   File "./duplicity/duplicity-0.5.16/usr/local/bin/duplicity", line
> 336, in full_backup
>     bytes_written = write_multivol("full", tarblock_iter, globals.backend)
>   File "./duplicity/duplicity-0.5.16/usr/local/bin/duplicity", line
> 205, in write_multivol
>     mf = manifest.Manifest().set_dirinfo()
>   File 
> "/home/mike/Code/deja-dup/tests/duplicity/duplicity-0.5.16/usr/local/lib/python2.6/site-packages/duplicity/manifest.py",
> line 54, in set_dirinfo
>     self.local_dirname = globals.local_path.name
> AttributeError: 'NoneType' object has no attribute 'name'
> 
> That stack doesn't make sense to me.  I'm not sure how it ended up in
> full_backup, let alone as a result of calling fn() which should always
> equal main()...
> 
> I don't get this error on 0.5.15.

Drat!  One more thing to add to unit tests, collection status on an
empty collection.  It works in all other cases.  It got there because of
a one-line change that I should have taken out along with some test code
and unit tests did not catch it.

Here's a patch that fixes the problem.

Thanks for the catch!

...Ken

Index: duplicity-bin
===================================================================
RCS file: /sources/duplicity/duplicity/duplicity-bin,v
retrieving revision 1.74
diff -u -r1.74 duplicity-bin
--- duplicity-bin       21 Apr 2009 19:34:17 -0000      1.74
+++ duplicity-bin       22 Apr 2009 02:34:02 -0000
@@ -765,7 +765,6 @@
         log.Notice(_("Last full backup date:") + " " + 
dup_time.timetopretty(last_full_time))
     else:
         log.Notice(_("Last full backup date: none"))
-        action = "full"
     if action == "inc" and last_full_time < globals.full_force_time:
         log.Notice(_("Last full backup is too old, forcing full backup"))
         action = "full"

signature.asc
Description: OpenPGP digital signature