[Pnet-developers] [patch #3582] Anchoring values is miscalculated

[Carl-Adam Brengesjo]

This is an automated notification sent by Savannah.
It relates to:
                patch #3582, project DotGNU Portable.NET

==============================================================================
 LATEST MODIFICATIONS of patch #3582:
==============================================================================

               Posted by: Carl-Adam Brengesjo <ptah>
               Posted on: 2005-01-16 21:30 (Europe/Stockholm)
    _______________________________________________________

                  Status:                    None -> Invalid                
             Open/Closed:                    Open -> Closed                 

    _______________________________________________________

Follow-up Comment:
My understanding is that Rich333 has _correctly_ solved this issue, which
apparently was caused by something completley different than this patch has
pointed out, and thus this item should be closed.

Closed as per above Sun 16th Jan 2005.

==============================================================================
 OVERVIEW of patch #3582:
==============================================================================

URL:
  <http://savannah.gnu.org/patch/?func=detailitem&item_id=3582>

                 Summary: Anchoring values is miscalculated
                 Project: DotGNU Portable.NET
            Submitted by: ptah
            Submitted on: Fri 12/17/2004 at 01:02
                Category: None
                Priority: 1 - Later
                  Status: Invalid
                 Privacy: Public
             Assigned to: ptah
        Originator Email: 
             Open/Closed: Closed

    _______________________________________________________


After some diggin' into the issues with the anchoring in winforms, reported
by Simon Guindon and described in
http://dotgnu.org/pipermail/developers/2004-November/012576.html
I was able to narrow it down being caused by the
prevParentWidth/prevParentHeight values in a child control is updated with
new values without the actual bounds of the control is updated, resulting in
the distance between the child bounds and it's parent increases.

I was able to *fix* this with not allowing not more than one call to
InitLayout() (see attached patch), as it was called multiple times and this
updating the fields as described above.

However, I'm not so familiar with the layout engine and uncertain how this
could affect real-world applications and thus I'm asking for some comments
and testing results on this patch so we, hopefully, can elimating creating
more bugs :)

    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 01/16/2005 at 21:30       By: Carl-Adam Brengesjo <ptah>
My understanding is that Rich333 has _correctly_ solved this issue, which
apparently was caused by something completley different than this patch has
pointed out, and thus this item should be closed.

Closed as per above Sun 16th Jan 2005.







    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 12/17/2004 at 01:23  Name: AnchoringTest.cs  Size: 1.23KB   By:
ptah
My testcase.
<http://savannah.gnu.org/patch/download.php?item_id=3582&item_file_id=3958>
-------------------------------------------------------
Date: Fri 12/17/2004 at 01:02  Name: anchoring_bug.patch  Size: 1.19KB   By:
ptah
Anchoring cache values patch.
<http://savannah.gnu.org/patch/download.php?item_id=3582&item_file_id=3957>

==============================================================================

This item URL is:
  <http://savannah.gnu.org/patch/?func=detailitem&item_id=3582>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/