[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Pnet-developers] Re: [DotGNU] How to submit a patch for
From: |
deryk |
Subject: |
Re: [Pnet-developers] Re: [DotGNU] How to submit a patch for |
Date: |
Mon, 10 Jan 2005 08:13:25 -0500 (EST) |
User-agent: |
SquirrelMail/1.4.3a |
> On Monday 10 January 2005 13:27, Marc Haisenko wrote:
>> Hi folks,
>> I'd like to submit one patch that fixes two or three bugs at once. For
>> one
>> bug there already is a bug report. How should I submit the patch ?
>> Should I
>> file two additional bug reports and then submit the patch to the patch
>> tracker with the note that it fixes bugs #123, #124 and #125 (for
>> example)
>> ? Or should I try to split it into three patches and attach those three
>> to
>> the bug reports ?
>> C'ya,
>> Marc
>
> I should add that it would be hard to split the patch into three parts, as
> I've split a function to fix one bug and the fix for another bug is also
> doing stuff in that function... I would have to do it in such a way that
> one
> would have to apply these patches in a specific order.
If one patch fixes two bugs (i.e. as mentioned above, shared code), I'd
imagine the best method would be to log a second bug, submit the patch and
mention that it fixes bug #xyz and bug #abc. The third bug, just submit a
patch for it without creating a bug report.
Deryk