Re: [Dolibarr-dev] Renaming getNomUrl

[Marcos García]

Good point Raphaël, I would prefer getHtmlLink than getLink because it looks like more as a property of the class.

Alexandre, why don't you analyze the signature of all usages and see if the difference is an intented behaviour? Since we are creating a new function we have the chance to correct all those differences.

Regards,

 

Marcos García

address@hidden

2014-10-14 17:16 GMT+02:00 Doursenaud, Raphaël <address@hidden>:

Hi all,

This method returns a full clickable link with either the object's name, icon or both.

With get*Url(), I expect to get a URL, not a fully formatted HTML content.

Thus, I'd prefer getLink() or getHtmlLink() because these better reflects its purpose.

+1 for the deprecated method wrapper to keep backward compatibility.

My 2 cents,

2014-10-13 17:44 GMT+02:00 Marcos García <address@hidden>:

I hope that too ;)

El 13/10/2014 17:41, "Christophe Battarel" <address@hidden> escribió:

Hello,

I agree with you for the getObjectUrl function name.

BUT i really hope that the old getNomUrl function will still remains for compatibility with all the external modules that use it !!!
(of course this old function should become just a call to the new one)

My two cents
Christophe

Le 13/10/2014 17:30, Marcos García a écrit :

Hi all:

Alexandre Spangaro (aspangaro) did a PR (https://github.com/Dolibarr/dolibarr/pull/1936#issuecomment-58801858) where some parts of the code got renamed and therefore translated to English.

I saw he translated getNomUrl function to getNameUrl, but then I thought a more appropiate name would be getObjectUrl, as we are geting the url of the object, not of the name.

What do you think?

Regards,

 

Marcos García

address@hidden

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

-- 
Christophe Battarel
Responsable technique
sarl altairis
Informatique et Web en Grésivaudan
33 Grande Rue
38570 Goncelin
09 52 71 70 96 (appel local)
address@hidden
http://www.altairis.fr 

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

--

Raphaël Doursenaud

Directeur technique (CTO)

Expert certifié en déploiement Google Apps

+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10

http://gpcsolutions.fr

Technopole Hélioparc

2 avenue du Président Pierre Angot

64053 PAU CEDEX 9

SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev