Re: [dmidecode] [PATCH 1/1] dmidecode: Get baseboard-location-in-chassis from -s option

[Talons Lee]

I can see this string from dmidecode -t2,
but can't get it directly from dmidecode -s.

I wanted to copy every string from host to a VM's settings.
Apparently it will be easier with this minor change.


On Thu, Apr 4, 2019 at 6:17 PM Jean Delvare <address@hidden> wrote:

> Hello Xin Li,
>
> On Thu,  4 Apr 2019 02:45:10 +0100, Xin Li wrote:
> > From: Xin Li <address@hidden>
>
> No description...
>
> > Signed-off-by: Xin Li <address@hidden>
> > ---
> >  dmiopt.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/dmiopt.c b/dmiopt.c
> > index 2f285f3..6d53c7e 100644
> > --- a/dmiopt.c
> > +++ b/dmiopt.c
> > @@ -162,6 +162,7 @@ static const struct string_keyword
> opt_string_keyword[] = {
> >       { "baseboard-version", 2, 0x06 },
> >       { "baseboard-serial-number", 2, 0x07 },
> >       { "baseboard-asset-tag", 2, 0x08 },
> > +     { "baseboard-location-in-chassis", 2, 0x0A },
> >       { "chassis-manufacturer", 3, 0x04 },
> >       { "chassis-type", 3, 0x05 },            /* dmi_chassis_type() */
> >       { "chassis-version", 3, 0x06 },
>
> I can't see the rationale for adding this option. Location in chassis
> is not a very popular attribute, most systems don't set it or set it to
> a useless string. As I understand it, this field is only useful for
> multi-board systems, which are rare. And then your option would return
> multiple strings, which is not really useful, as you don't know which
> location relates to which board.
>
> What is your use case?
>
> --
> Jean Delvare
> SUSE L3 Support
>