Re: Gorm patches to review

[Fred Kiefer]

I never saw that mail on the bug mailing list. looks like it takes some
time there to get through.
I just updated the definition of NSDragOperation in gui, hopefully I
found all the places where this needs to be changed.
This should pave the way for the Gorm change. On the other hand,
NSDragOperation is now defined as unsigned int, so the change in Gorm
isn't strictly needed any more. Although I think it is always better to
use the explicit type not just the underlying one.

Fred

Am 22.12.2010 13:27, schrieb Philippe Roussel:
> I am not sure anyone reads bug-gnustep@gnu.org so I'm trying here.
> 
> Philippe
> 
> -------- Message transféré --------
> De: Philippe Roussel <p.o.roussel@free.fr>
> À: bug-gnustep@gnu.org
> Sujet: Gorm patches to review
> Date: Tue, 21 Dec 2010 14:27:35 +0100
> 
> Hi,
> 
> Lately I had problems with Gorm logging (with libobjc2) messages such as 
> 
> Calling [GormObjectEditor -draggingUpdated:] with incorrect signature.
> Method has I24@0:8@16, selector has i24@0:8@16
> 
> and not being able to connect an NSBox to an outlet. Following Fred
> Kiefer's advice I changed -draggingUpdated: return type to
> NSDragOperation.
> I also changed the return type of draggingSourceOperationMaskForLocal:
> as per Apple documentation but this should also be done in gnustep-gui
> so I'm not sure it's a good idea to do it on Gorm just now.
> 
> With the patch applied I can connect a NSBox to an outlet by dragging
> the NSOwner icon to the NSBox. Don't ask me why but it works...
> 
> The second patch fixes what seems to be a typo.
> 
> Hope this helps,
> Philippe
>