Re: NSTableView fix

[Lars Sonchocky-Helldorf]

Am 30.08.2007 um 01:00 schrieb Andreas Höschler:

> NSTableView
> Check whether delegate responds to  
> control:didFailToFormatString:errorDescription: before sending  
> message and a bunch of other important fixes.
>
> - (void)validateEditing
> {
>   if (_textObject)
>     {
>       NSFormatter *formatter;
>       NSString *string;
>       id newObjectValue = nil; // <----

While it might be easier for you just to add those "// <----" to your  
changed source and send it here, the problem with that is that the  
reviewers can easily miss or skip such a comment (searching for it is  
also not that save since who knows if you typed one of those  
differently in accident). I think it would be much easier for the  
developers if you did a

diff -u /path/to/original/file /path/to/changed/file > /path/to/ 
patchfile.patch

If you don't have the habit to keep the original files around have a  
look here how to patch against the SVN:

http://wiki.creativecommons.org/HOWTO_Patch

and sent the patchfile.patch here. That patchfile.patch can then be  
applied to the sources using the patch command. So this is much less  
error prone.


Thanks,

        Lars