discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NSTabView Fix


From: Andreas Höschler
Subject: NSTabView Fix
Date: Fri, 23 Feb 2007 22:51:06 +0100

Hello all,

somebody has modified the following NSTabView.m method recently. Don't do that!

- (void) insertTabViewItem: (NSTabViewItem*)tabViewItem
                   atIndex: (int)index
{
  [tabViewItem _setTabView: self];
  [_items insertObject: tabViewItem atIndex: index];

/*  *** You do not really want to do that; think about it!!!
 if ((_selected_item != NSNotFound) && (index <= _selected_item))
    {
     _selected_item++;
    }*/

  if ([_delegate respondsToSelector:
    @selector(tabViewDidChangeNumberOfTabViewItems:)])
    {
      [_delegate tabViewDidChangeNumberOfTabViewItems: self];
    }

  /* TODO (Optimize) - just mark the tabs rect as needing redisplay */
  [self setNeedsDisplay: YES];
}

Regards,

  Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]