discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re2: Crash when trying to load corrupt file with NSDictionary -initWithC


From: Roland Schwingel
Subject: Re2: Crash when trying to load corrupt file with NSDictionary -initWithContentsOfFile:
Date: Thu, 30 Jun 2005 10:22:45 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040910

Hi Richard...

Richard Frith-Macdonald <richard@brainstorm.co.uk> wrote on 30.06.2005 09:46:52:
> On 2005-06-30 08:02:40 +0100 Roland Schwingel
> <roland.schwingel@onevision.de> wrote:
> > [...]
> > Hope this patch can be applied
>
> I applied a slightly different (more general purpose I hope) fix, intended
> to catch all cases of bad cross references.
> It's in CVS ... I'd appreciate feedback on how it works for you...

Unfortunately it does not work and the reason is clear. With my corrupt file info->didUnique is set to 0 in initDeserializerInfo(), so the GSIArray is also not initialized and calling GSIArrayCount(&info->array) accesses uninitialized data. Access to the GSIArray should only be done after checking the didUnique flag.

Roland





reply via email to

[Prev in Thread] Current Thread [Next in Thread]