Hi Jawad,
ahhh you're right, of course! I was missing that the callback
actually is set in the grc xml file to a lambda that calls
recv_packet, so that's where the checking whether the CRC was
correct happens :)
So, yes, I think the logic involved here is OK, but Sang Hyuk is
still seeing problems.
So: You say packets for which the CRC is not correct still get
accepted. What does "accepted" mean in the context? as far as I can
tell, they don't get inserted into the output message queue:
def recv_pkt(self, ok, payload):
msg = gr.message_from_string(payload, 0, self._item_size_out,
len(payload)/self._item_size_out)
if ok: self._msgq_out.insert_tail(msg)
because for them, "ok" is "False".
Do they still appear on the output of the packet decoder?
Best regards,
Marcus
On 21.02.2016 15:22, Jawad Seddar
wrote:
Hi all,
The packet decoder block uses packet_utils module
(namely the packet_utils.unmake_packet() function) found in
gr-digital.
The crc check occurs in the unmake_packet function.
The logic in that function is correct, what do you
think is wrong with returning actual == expected?
Regards,
Jawad
Le 21 févr. 2016 14:26, "Marcus Müller"
<
address@hidden>
a écrit :
OK, sadly that means
I'm even more confused :(
packet_decoder doesn't have any CRC checking!
Best regards,
Marcus
On 21.02.2016 14:20, SangHyuk Kim wrote:
No! I'm using current version. the link was
just for showing.!
_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio