Re: [Discuss-gnuradio] GRC: wrong input declaration in sample_and_hold

[Alberto Trentadue]

Yes.
I had the "ctrl" sink declared as "<type>$type</type>" in my build (V3.2.2 
built from the tarball).
I guess it has 
been corrected now.
Thanks
Alberto

On Fri, 2010-05-28 at 17:05 -0700, Josh Blum wrote:
This is the sample and hold c++ 
io signature:
> 
> @NAME@::@NAME@ ()
>    : gr_sync_block ("@BASE_NAME@",
>                  gr_make_io_signature2 (2, 2, sizeof 
(@I_TYPE@), sizeof(char)),
>                  gr_make_io_signature (1, 1, sizeof (@O_TYPE@))),
>      d_data(0)
> {
> }
> 
> this 
is the grc xml block io signature:
> 
>       <sink>
>               <name>in</name>
>               <type>$type</type>
>       </sink>
>       <sink>
>               
<name>ctrl</name>
>               <type>byte</type>
>       </sink>
>       <source>
>               <name>out</name>
>               <type>$type</type>
>       </source>

> 
> Looks correct?
> -Josh
> 
> 
> On 05/28/2010 03:32 PM, Alberto Trentadue wrote:
> > Hello
> >
> > I think I found 
a wrong input declaration in the sample_and_hold GRC block.
> > The "control" input is defined to be
> > of the same 
data type of "in" and "out". Instead, it should be a byte.
> >
> > This is the fix I have applied:
> >
> >
> > 
address@hidden gnuradio]$ diff -c 
./share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml.orig .
> > 
/share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml
> > *** ./share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml.orig      

> > 2010-05-28 23:29:32.953460291 +0200
> > --- ./share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml   2010-05-28 23:
29:
> > 57.655461060 +0200
> > ***************
> > *** 40,46 ****
> >     </sink>
> >     <sink>
> >             
<name>ctrl</name>
> > !           <type>$type</type>
> >     
> > </sink>
> >     <source>
> >             <name>out</name>
> > --- 
40,46 ----
> >     </sink>
> >     <sink>
> >             <name>ctrl</name>
> > !           
> > <type>byte</type>
> >     </sink>
> 
>       <source>
> >             <name>out</name>
> >
> > BTW: what is the need to use a "char" as control in the
> > 
correspondent gr block?
> >
> > Moreover, it seems to me that the Documentation is wrong, because the block 
> > samples the 
input
> > when the ctrl is 1, and holds when is 0, not the opposite.
> > Do you agree?
> >
> > Alberto-
> >
> >
> > 
Risparmia con Tutto Incluso Light: telefono + adsl 8 mega a soli 14,95 € al 
mese.
> >
> > Gratis la Sim Tiscali Mobile 
con 25 euro di traffico!
> >
> > L'offerta è valida solo se attivi entro il 03/06/10
> >
> > http://abbonati.tiscali.
it/telefono-adsl/prodotti/tc/tuttoincluso_light/?WT.mc_id=01fw
> >
> > _______________________________________________

> > Discuss-gnuradio mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/discuss-
gnuradio
> 
> _______________________________________________
> Discuss-gnuradio mailing list
> address@hidden
org
> http://lists.gnu.org/mailman/listinfo/discuss-gnuradio


Risparmia con Tutto Incluso Light: telefono + adsl 8 mega a soli 14,95 € al 
mese.

Gratis la Sim Tiscali Mobile con 25 euro di traffico! 

L'offerta è valida solo se attivi entro il 03/06/10

http://abbonati.tiscali.it/telefono-adsl/prodotti/tc/tuttoincluso_light/?WT.mc_id=01fw