discuss-gnuradio
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Discuss-gnuradio] FreeBSD patches for gnuradio


From: Greg Troxel
Subject: Re: [Discuss-gnuradio] FreeBSD patches for gnuradio
Date: Wed, 23 May 2007 09:06:17 -0400
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/21.4 (berkeley-unix)

Is the gr-radio-astronomy patch a FreeBSD fix, or generic?

ppdev.c:

I don't see why the include of sstream is conditional on the various pp
methods.

The diff seems to add code for Linux as well, but I wonder if that's an
artifact of how diff chose to deal with before/after.

Other than that question and nits, at first glance this looks fine, but
you're probably over that pesky copyright assignment threshold...






reply via email to

[Prev in Thread] Current Thread [Next in Thread]