Re: [Discuss-gnuradio] updating abstract classes

[Eric Blossom]

On Wed, Apr 26, 2006 at 06:35:27PM -0400, Ilia Mirkin wrote:
> Quoting Charles Swiger <address@hidden>:
> 
> >Another modules, atsc_fs_checker, which also has some abstract
> >classes DOES compile and run on meaningless streams w/o segfault
> >so I can go by that (tomorrow!).
> >
> >
> >Yeah - here's what I left out (arg!)
> >
> > d_equalizer = equalizer;
> >
> >
> >--Chuck
> 
> Yeah, so while atsci_equalizer doesn't implement these things,
> atsci_equalizer_{lms,lms2,nop} do implement them. So you want something 
> along
> the lines of
> 
> atsci_equalizer *d_equalizer;
> 
> and somewhere in the code, do
> 
> d_equalizer = create_atsci_equalizer_nop() or something.
> 
> If d_equalizer points to a properly set up object, and ->filter() segfaults,
> then there must be a bug in the filter() routine (or the inputs to it are
> sufficiently wrong.)
> 
>  -Ilia

Hi Ilia,
Thanks for diving in.

Chuck,

After taking a look at the 0.9 code (atsc_rx.cc), it looks like we were
instantiating atsci_equalizer_lms.

atsci_equalizer_lms uses a single FIR filter.

atsci_equalizer_lms2 uses feedback and feedforward.  Not sure we ever
got it sorted out.


Eric