Re: [Denemo-devel] F25 build error for 2.1

[Richard Shann]

On Thu, 2017-04-27 at 13:24 +0200, Johan Vromans wrote:
> Building 2.1 for Fedora 25 fails due to a missing semicolon in
> denemo-2.1/pixmaps/denemo.desktop. The line
> 
> Categories=GNOME;Audio;AudioVideo;Music;Education
> 
> should have a final semicolon. During install, rpmbuild executes the command
> 
>   desktop-file-install --vendor=""\
>       --dir=%{buildroot}/%{_datadir}/applications\
>       --add-category=X-Notation\
>       %{buildroot}/%{_datadir}/applications/denemo.desktop
> 
> This appends "X-Notation;" at the end of the Categories line, resulting in
> an invalid Category "EducationX-Notation".
> 
> Yes, one can argue
>  that desktop-file-install should do a better job

yes, you're right, it is a bug in rpmbuild, but as we can harden the
file against this misuse we may as well. (I've don't know anything about
this file, it seems to be located in a very bizarre directory).
Fix is in git now.

Richard