Re: [Denemo-devel] Windows build failure

[Richard Shann]

On Sat, 2013-11-16 at 11:54 +0100, Éloi Rivard wrote:
> This is fixed.

hmm, the build just failed again .... I didn't spot this in your commit:


-  if(!g_hash_table_contains (the_keymap->commands, &command_id)){
+  if(g_hash_table_contains (the_keymap->commands, &command_id) ==
NULL){

I guess it should be g_hash_table_lookup()? I'll push that and try
again.
Richard


> 
> Windows build should be added to Travis to avoid such things. Do you
> still use gub to build denemo ?
> 
> 
> 
> 2013/11/16 Richard Shann <address@hidden>
>         Eloi,
>         
>         It seems that g_hash_table_contains() is causing the windows
>         build to
>         barf. Looking up the docs I see it is only
>         Since 2.32
>         You may be able to substitute g_hash_table_lookup () if you
>         are not
>         storing NULL pointers or the value 0, otherwise
>         g_hash_table_lookup_extended () could be used I think. This
>         could be
>         conditional on the glib version so that we can easily drop it
>         when we
>         manage to advance the windows libraries to more modern values.
>         
>         Richard
>         
>         On Fri, 2013-11-15 at 16:40 -0600, Jeremiah Benham wrote:
>         > I tried to rebuild and it does bard on denemo.
>         > Here is the log:
>         >
>         > http://denemo.org/~rshann/gub/target/mingw/log/denemo.log
>         >
>         > Here is the error:
>         > kbd-custom.o:kbd-custom.c:(.text+0x14a2): undefined
>         reference to `_g_hash_table_contains'
>         > kbd-custom.o:kbd-custom.c:(.text+0x1609): undefined
>         reference to `_g_hash_table_contains'
>         > keyboard.o:keyboard.c:(.text+0x70d): undefined reference to
>         `_g_hash_table_contains'
>         > collect2: ld returned 1 exit status
>         >
>         > Jeremiah
>         
>         
>         
> 
> 
> 
> -- 
> Éloi Rivard - address@hidden
>         
> « On perd plus à être indécis qu'à se tromper. »
>