Re: [Cvs-dev] cvs-passwd patch: weird problem

[Prasad J Pandit]

  Hello Mark :)

On Sat, 19 Aug 2006, Mark D. Baushke wrote:
> What output do you get with the following commands on your FC5 system:
>
>     uname -a
>     gcc -v
>     cat /etc/redhat-release
>
> If you see something like this:
>
> % uname -a
> Linux prasad-fc5 2.6.15-1.2054_FC5smp #1 SMP Tue Mar 14 16:05:46 EST 2006 i686 
> i686 i386 GNU/Linux
> % gcc -v
> Using built-in specs.
> Target: i386-redhat-linux
> Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
> --infodir=/usr/share/info --enable-shared --enable-threads=posix 
> --enable-checking=release --with-system-zlib --enable-__cxa_atexit 
> --disable-libunwind-exceptions --enable-libgcj-multifile 
> --enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk 
> --disable-dssi --with-java-home=/usr/lib/jvm/java-1.4.2-gcj-1.4.2.0/jre 
> --with-cpu=generic --host=i386-redhat-linux
> Thread model: posix
> gcc version 4.1.1 20060525 (Red Hat 4.1.1-1)
> % cat /etc/redhat-release
> Fedora Core release 5 (Bordeaux)

  Yes, it looks pretty much the same.

>  bash
>  CFLAGS='-g -O2 -fno-strict-aliasing' ./configure
>  grep ^CFLAGS src/Makefile
>  # You should see something like: CFLAGS = -g -O2 -fno-strict-aliasing
>  make
>
> I believe that things should work fine for the compilation. If not,
> please let us know what happens.

  I tried it, but nothing changed.

>  make check
>
> Well, there is no way that running this will do me any good. I do not
> have and will NEVER run :pserver: on any machine of my own. I am not
> a fan of it and never will be a fan of it.

  hmmn, now that's a question of personal choice, which dependes upon so 
many things,& so many factors, right? And trust me, I respect all of them 
equally. So, no offence !?! :)

> different. It is possible that gcc may be sensative to other problems
> such that writing the code this way:
>
>    case PASSWD:    /* change password */
>        if (argc < 2)
>            error (1, 0, "insufficient arguments");
>        str = xstrdup (argv[1]);
>        if (do_encrypt)
>            pass = encrypt_pass (descramble (str));
>        else
>            pass = descramble (str);
>        change_pass (usr, pass);
>        free (str);
>        break;

  I tried this also, but no change.

> Use' bool do_encrypt = false;' rather than 'short do_encrypt = 0;'
> and 'do_encrypt = true;' rather than 'do_encrypt = 1;'
>
> I don't understand why mode is not of type enum op_mode given that you
> take pains to define the enum right above it.
>
> in check_option(), be adivsed that 'c' should be an int rather than a
> char (the getopt() function returns an int). You need to do this to
> avoid problems on systems where char is signed.

  okay, I'll do the changes! :) :)


Thank you so much for all the wonderful information!
--
regards
   -Prasad
PS: Please don't send me html/attachment/Fwd mails