cvs-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Cvs-dev] sanity.sh on FreeBSD 5.x and FreeBSD 6.x


From: Mark D. Baushke
Subject: [Cvs-dev] sanity.sh on FreeBSD 5.x and FreeBSD 6.x
Date: Tue, 13 Jun 2006 17:31:36 -0700

Hi Folks,

The basic problem is that /bin/expr on FreeBSD 5.2 and FreeBSD 6.1
now has a new '-e' argument

% expr "-rw-" : "-rw-"
expr: illegal option -- r
usage: expr [-e] expression
% expr -- "-rw-" : "-rw-"
4
% uname -s -r
FreeBSD 6.1-RELEASE
%


On older FreeBSD systems

% expr "-rw-" : "-rw-"
4
% expr -- "-abc" : "-abc"
expr: syntax error
% uname -s -r
FreeBSD 4.2-RELEASE
%


There are a number of possible ways to work around this problem.

One that I came up with that seems to do the trick is the patch given
below.

There would be other ways to handle it, such as setting EXPR_COMPAT=true
which I do not really like or recasting things into an even more
complicated command.

Does anyone have any opinions on this topic?

ChangeLog entry:

        * sanity.sh: Determine if the expr to be used will be confused
        by 'expr "-rw-rw-r--" : "-rw-rw-r--"' and if it may be hacked
        around using 'expr -- "-rw-rw-r--" : "-rw-rw-r--"' or not.

Index: sanity.sh
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/sanity.sh,v
retrieving revision 1.1153
diff -u -p -r1.1153 sanity.sh
--- sanity.sh   11 Jun 2006 14:35:16 -0000      1.1153
+++ sanity.sh   14 Jun 2006 00:19:07 -0000
@@ -1143,6 +1143,29 @@ else
 fi
 }
 
+# FreeBSD 5.2 and 6.1 support 'expr [-e] expression' 
+# they get confused unless '--' is used before the expressions
+# when those expressions begin with a '-' character, such as the
+# output of an ls -l command.
+exprDASHDASH='false'
+expr_set_DASHDASH ()
+{
+expr=$1
+exprDASHDASH='false'
+if $expr $exprDASHDASH "-rw-rw-r--" : "-rw-rw-r--" >/dev/null 2>&1; then
+  # good, it works
+  return 0
+else
+  if $expr -- "-rw-rw-r--" : "-rw-rw-r--" >/dev/null 2>&1; then
+    exprDASHDASH=':'
+    return 0
+  else
+    return 77
+  fi
+fi
+}
+
+
 EXPR=`find_tool expr ${EXPR}:gexpr \
   version_test expr_tooltest1 expr_tooltest2 expr_tooltest3 \
 expr_set_ENDANCHOR expr_set_DOTSTAR expr_tooltest_DOTSTAR`
@@ -1151,6 +1174,10 @@ expr_set_ENDANCHOR expr_set_DOTSTAR expr
 expr_set_ENDANCHOR ${EXPR} >/dev/null
 expr_tooltest_DOTSTAR ${EXPR} >/dev/null
 
+# Set the exprDASHDASH for the chosen expr version
+expr_set_DASHDASH ${EXPR}
+[ $exprDASHDASH ] && EXPR="$EXPR --"
+
 echo "Using EXPR=$EXPR" >>$LOGFILE
 echo "Using ENDANCHOR=$ENDANCHOR" >>$LOGFILE
 echo "Using DOTSTAR=$DOTSTAR" >>$LOGFILE


 ------- man page for expr -------

% man expr | ul -tdumb
EXPR(1)                 FreeBSD General Commands Manual                EXPR(1)

NAME
     expr -- evaluate expression

SYNOPSIS
     expr [-e] expression

DESCRIPTION
     The expr utility evaluates expression and writes the result on standard
     output.

     All operators and operands must be passed as separate arguments.  Several
     of the operators have special meaning to command interpreters and must
     therefore be quoted appropriately.  All integer operands are interpreted
     in base 10.

     Arithmetic operations are performed using signed integer math.  If the -e
     flag is specified, arithmetic uses the C intmax_t data type (the largest
     integral type available), and expr will detect arithmetic overflow and
     return an error indication.  If a numeric operand is specified which is
     so large as to overflow conversion to an integer, it is parsed as a
     string instead.  If -e is not specified, arithmetic operations and pars-
     ing of integer arguments will overflow silently according to the rules of
     the C standard, using the long data type.

     Operators are listed below in order of increasing precedence; all are
     left-associative.  Operators with equal precedence are grouped within { }
     symbols.

     expr1 | expr2
             Return the evaluation of expr1 if it is neither an empty string
             nor zero; otherwise, returns the evaluation of expr2.

     expr1 & expr2
             Return the evaluation of expr1 if neither expression evaluates to
             an empty string or zero; otherwise, returns zero.

     expr1 {=, >, >=, <, <=, !=} expr2
             Return the results of integer comparison if both arguments are
             integers; otherwise, returns the results of string comparison
             using the locale-specific collation sequence.  The result of each
             comparison is 1 if the specified relation is true, or 0 if the
             relation is false.

     expr1 {+, -} expr2
             Return the results of addition or subtraction of integer-valued
             arguments.

     expr1 {*, /, %} expr2
             Return the results of multiplication, integer division, or
             remainder of integer-valued arguments.

     expr1 : expr2
             The ``:'' operator matches expr1 against expr2, which must be a
             basic regular expression.  The regular expression is anchored to
             the beginning of the string with an implicit ``^''.

             If the match succeeds and the pattern contains at least one regu-
             lar expression subexpression ``\(...\)'', the string correspond-
             ing to ``\1'' is returned; otherwise the matching operator
             returns the number of characters matched.  If the match fails and
             the pattern contains a regular expression subexpression the null
             string is returned; otherwise 0.

     Parentheses are used for grouping in the usual manner.

     The expr utility makes no lexical distinction between arguments which may
     be operators and arguments which may be operands.  An operand which is
     lexically identical to an operator will be considered a syntax error.
     See the examples below for a work-around.

     The syntax of the expr command in general is historic and inconvenient.
     New applications are advised to use shell arithmetic rather than expr.

   Compatibility with previous implementations
     Unless FreeBSD 4.x compatibility is enabled, this version of expr adheres
     to the POSIX Utility Syntax Guidelines, which require that a leading
     argument beginning with a minus sign be considered an option to the pro-
     gram.  The standard -- syntax may be used to prevent this interpretation.
     However, many historic implementations of expr, including the one in pre-
     vious versions of FreeBSD, will not permit this syntax.  See the examples
     below for portable ways to guarantee the correct interpretation.  The
     check_utility_compat(3) function (with a utility argument of ``expr'') is
     used to determine whether compatibility mode should be enabled.  This
     feature is intended for use as a transition and debugging aid, when expr
     is used in complex scripts which cannot easily be recast to avoid the
     non-portable usage.  Enabling compatibility mode also implicitly enables
     the -e option, since this matches the historic behavior of expr in
     FreeBSD.  For historical reasons, defining the environment variable
     EXPR_COMPAT also enables compatibility mode.

ENVIRONMENT
     EXPR_COMPAT  If set, enables compatibility mode.

EXIT STATUS
     The expr utility exits with one of the following values:
     0       the expression is neither an empty string nor 0.
     1       the expression is an empty string or 0.
     2       the expression is invalid.

EXAMPLES
     +   The following example (in sh(1) syntax) adds one to the variable a:
               a=$(expr $a + 1)

     +   This will fail if the value of a is a negative number.  To protect
         negative values of a from being interpreted as options to the expr
         command, one might rearrange the expression:
               a=$(expr 1 + $a)

     +   More generally, parenthesize possibly-negative values:
               a=$(expr \( $a \) + 1)

     +   This example prints the filename portion of a pathname stored in
         variable a.  Since a might represent the path /, it is necessary to
         prevent it from being interpreted as the division operator.  The //
         characters resolve this ambiguity.
               expr "//$a" : '.*/\(.*\)'

     The following examples output the number of characters in variable a.
     Again, if a might begin with a hyphen, it is necessary to prevent it from
     being interpreted as an option to expr.

     +   If the expr command conforms to IEEE Std 1003.1-2001 (``POSIX.1''),
         this is simple:
               expr -- "$a" : ".*"

     +   For portability to older systems, however, a more complicated command
         is required:
               expr \( "X$a" : ".*" \) - 1

SEE ALSO
     sh(1), test(1), check_utility_compat(3)

STANDARDS
     The expr utility conforms to IEEE Std 1003.1-2001 (``POSIX.1''), provided
     that compatibility mode is not enabled.  The -e flag is an extension.

FreeBSD 6.1                      July 12, 2004                     FreeBSD 6.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]