Re: [Cvs-dev] Re: Result of CVS Coverity scan, via NetBSD

[Christos Zoulas]

On May 12,  8:18am, address@hidden ("Mark D. Baushke") wrote:
-- Subject: Re: [Cvs-dev] Re: Result of CVS Coverity scan, via NetBSD

| > | Would it make sense to modify src/gnu/usr.bin/cvs/include/config.h
| > | so that it does a
| > | 
| > | /* Functions defined in src/gnu/dist/xcvs/src/subr.c */
| > | #define xasprintf cvs_xasprintf
| > | #define xmalloc   cvs_xmalloc
| > | #define xrealloc  cvs_xrealloc
| > | #define xstrdup   cvs_xstrdup
| > | 
| > | or, does the coverity model processing not handle macro processing
| > | correctly?
| > 
| > It does, and it will work properly [provided it compiles :-)]
| 
| You might give it a try and see if it works for you.

I've done this and added all the rest of the `x' functions for completeness.
It works fine.

| Agreed. The patch below reverts those changes and adds a few asserts to
| deal with the other cases. I have committed it to the CVS STABLE branch
| (1.11.x).

Great, I just applied it. Now I need to get the coverity folks to give
use a fresh run...

Thanks a lot,

christos