[cvg-moodle-devel] Code cleanup + Broken Animal?

[Juan Pedro Bolivar Puente]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I have been doing some code cleanup in Vizcosh today and just made a
commit. I added a ChangeLog file so you can follow the changes there.
This code clean-up fixes some bugs related to thumbnails not being shown
and eliminates all the need for temporary files. While reading the code
I noticed that the infamous 'tmp' folder inside the distribution is not
needed at all, as all the visualization data and thumbnails are actually
stored in the database. I am not very experienced with databases so I do
no know if this aproach (storing files in a database table) can cause
effiency problems in the future, but I leave it this way because it
actually makes things quite easier, as using file storage can always
cause problems of "file leaks" (for example, when deleting a course...).
There where some weird things in the previous code... I have been
deleting quite a lot of code that is not needed --replaced by PHP and/or
Moodle functions.

Some things might be broken now --AFAIK, the "search by author"
functionality is the only "by design" new bug introduced, but I might
have made mistakes in my refactoring :D

Another thing I changed is that we no longer need that "Download and
Run" annoying window, that in some browsers actually prevented the jnlp
being downloaded at all --for some unknown reasons. Clicking on the
thumbnail now downloads the jnlp file.

Also, there is a problem that I do not know how to fix. The animations
lAunch well (only tried Animal animations) but Animal goes "segfault"
(java.lang.NullPointerExpection) just after loading. The only cause I
can find for this is that the parameter path now looks like this:
http://some-site/vizcosh/dl_data.php?id=3 instead to a something like:
http://some-site/vizcosh/tmp/file.aml file. Anyway, this /should/ work,
as actually visiting that address makes you download a .aml file (the
http connection headers are tuned up so the filename and everything is
ok). Maybe there is a problem in Animal visualization download code? Can
you Guido check it?

I hope you like the changes. Any suggestions are welcome :-)

Thanks,

JP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqquQ8ACgkQchi8veCammdz9wCeMnG67/HxhpzTnh5MUgpXx6VD
26AAn28fb97gOuaPOzSIRpacN71SDM5r
=Kj48
-----END PGP SIGNATURE-----