Re: Symlink grouping with --group-directories-first in ls

[Pádraig Brady]

On 05/01/19 08:16, Pádraig Brady wrote:
> On 28/12/18 00:20, Assaf Gordon wrote:
>> Hello Pádraig,
>>
>> On 2018-12-27 7:37 a.m., Pádraig Brady wrote:
>>> On 23/12/18 19:35, Amin Bandali wrote:
>>>>
>>>> It would be great if ls had an option to group directory symlinks with
>>>> the real directories when --group-directories-first is specified.
>>>
>>> Good point.
>>> It probably should just do that with no other options.
>>> The attached implements that.
>>>
>>
>> A cursory test seem to indicate this doesn't work on Free/OpenBSDs
>> (but works well on Debian).
>>
>> On BSDs, inside "is_linked_directoccry", when visiting a
>> symlink-to-direcotory, f->filetype=6 (which is symlink), but
>> f->linkmode is zero, so S_ISDIR(f->linkmode) returns false.
>>
>> When adding "-L" (dereference symlinks), it works as expected
>> (but in such cases, f->filetype=3, not 6).
>>
>> I'm happy to test more on BSDs if needed, and also my BSD virtual
>> machines are now in the gcc-compile-farm making testing even
>> easier (https://cfarm.tetaneutral.net/machines/list/).
>>
>> Lastly,
>>
>> In the commit message, I suggest:
>>     s/used/use/
>> and
>>    Suggested by Amin Bandali in
>>    https://lists.gnu.org/r/coreutils/2018-12/msg00017.html
> 
> I updated to fix to always set check_symlink_mode with --group.
> I also simplified gobble_file() a bit to unconditionally set linkmode.

Pushed after testing within a FreeBSD 10 pretest VM

cheers,
Pádraig