[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] base64: fix 'extra operand' error message
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] base64: fix 'extra operand' error message |
|
Date: |
Wed, 19 Dec 2018 15:26:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 |
On 12/19/18 9:10 AM, Assaf Gordon wrote:
> Hi all,
>
> I noticed this small issue in base64 (seems the code is from
> the original commit in 2006 when switching to git).
>
> WDYT?
> -assaf
Nice catch!
Comments:
* base32 is affected, too. It's the same source, but the fix should
be mentioned for both programs.
* this is a user-visible change, therefore it deserves a NEWS entry.
* a test may be good, wouldn't it?
Thanks & have a nice day,
Berny