[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tests: fix tail test race causing false failure
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH 2/2] tests: fix tail test race causing false failure |
|
Date: |
Tue, 31 Jan 2017 22:36:34 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 31/01/17 22:03, Jim Meyering wrote:
> Nice work, eliminating another test race condition.
>
> On Tue, Jan 31, 2017 at 9:41 PM, Pádraig Brady <address@hidden> wrote:
>> +grep -F 'become accessible' out || # usual case
>> +grep -F 'has appeared' out || { fail=1; cat out; } # with slow rmdir
>
> I would find that more readable with a single grep with -E+| for
> alternation, instead of two invocations and "||"?
>
> # The first is the common case, "has appeared" arises with slow rmdir.
> grep -E 'become accessible|has appeared' out || { fail=1; cat out; }
>
agreed. thanks