coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] factor: remove outdated conditional


From: Tim Bücher
Subject: Re: [PATCH] factor: remove outdated conditional
Date: Wed, 06 Jul 2016 23:19:09 +0200

I'm sorry, seems like i messed something up there.
Good night.

Am Mi, 6. Jul, 2016 um 11:03 schrieb Pádraig Brady <address@hidden>:
On 06/07/16 21:56, Tim Bücher wrote:
 diff --git a/src/factor.c b/src/factor.c
 index 8fee759..27e836b 100644
 --- a/src/factor.c
 +++ b/src/factor.c
 @@ -215,12 +215,6 @@ const unsigned char factor_clz_tab[129] =

  #endif

 -#if !defined __clz_tab && !defined UHWtype
 -/* Without this seemingly useless conditional, gcc -Wunused-macros
 -   warns that each of the two tested macros is unused on Fedora 18.
 -   FIXME: this is just an ugly band-aid.  Fix it properly.  */
 -#endif
 -
  /* 2*3*5*7*11...*101 is 128 bits, and has 26 prime factors */
  #define MAX_NFACTS 26


Did you test it with -Wunused-macros ?
It still gives an error here with gcc 5.3.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]