[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: remove form feed characters from sources
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] maint: remove form feed characters from sources |
|
Date: |
Mon, 14 Dec 2015 02:41:41 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 14/12/15 01:57, Jim Meyering wrote:
> On Sun, Dec 13, 2015 at 12:21 PM, Pádraig Brady <address@hidden> wrote:
>> maint: remove form feed characters from sources
>>
>> These are no longer useful and can impact viewing
>> patches in some mail programs for example.
>>
>> * src/cksum.c: Remove ^L characters.
>> * src/comm.c: Likewise.
>> * src/kill.c Likewise.
>> * src/ln.c Likewise.
>> * src/nl.c Likewise.
>> * src/pr.c Likewise.
>> * src/ptx.c Likewise.
>> * src/split.c Likewise.
>> * src/tr.c Likewise.
>> * src/tsort.c Likewise.
>> * src/uniq.c Likewise.
>> * src/wc.c Likewise.
>
> Great! Thank you.
> Perhaps add a syntax-check rule too?
Not likely to be be reintroduced, but fair enough :)
I used $'\f' in the rule below to avoid using a literal ^L,
as it should be well supported by developer shells.
+sc_prohibit-form-feed:
+ @prohibit=$$'\f' \
+ in_vc_files='\.[chly]$$' \
+ halt='Form Feed (^L) detected' \
+ $(_sc_search_regexp)
thanks,
Pádraig.