coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: false-positive failure of the root-removal test


From: Jim Meyering
Subject: Re: false-positive failure of the root-removal test
Date: Thu, 15 Oct 2015 08:13:12 -0700

On Thu, Oct 15, 2015 at 3:57 AM, Pádraig Brady <address@hidden> wrote:
> On 15/10/15 11:33, Bernhard Voelker wrote:
>> On 10/15/2015 11:32 AM, Pádraig Brady wrote:
>>> How about the attached on top?
>>
>> I'm now on a newer openSUSE host where GDB doesn't have this bug anymore,
>> but from reading the patch looks good ... except this tiny typo:
>>
>>> * tests/rm/r-root.sh: SKip the test if there are gdb warnings
>>
>> s/SKip/Skip/
>>
>> Another issue: during the creation of the test, I forgot to initialize
>> the variable CU_TEST_SKIP_EXIT at the very beginning.  It's unlikely
>> that someone has such a variable set, but would you mind to squash
>> an 'unset CU_TEST_SKIP_EXIT' into the commit?
>
> Pushed with those adjustments.

Here's a small improvement:

Attachment: 0001-tests-tweak-sed-expressions-in-rm-r-root.sh.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]