coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'syntax-check' minor portability issues


From: Pádraig Brady
Subject: Re: 'syntax-check' minor portability issues
Date: Thu, 08 Jan 2015 12:43:59 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

On 08/01/15 06:25, Assaf Gordon wrote:
> Hello,
> 
> two rules in 'syntax-check' fail with non-gnu tools:
> 
> sc_long_lines (cfg.mk): uses 'wc -L' and 'sed -r' - not supported on BSD's 
> wc/sed.

They are supported on FreeBSD actually.
wc -L since FreeBSD 7.2 and sed -r since 8.1.
OS X's tools are older than that.

> perhaps it should even use '$(SED)' instead of 'sed'?

Maybe in future.

> _gl_tight_scope (gnulib/top/maint.mk): uses 'nm -e', '-e' not supported with 
> Apple Xcode's nm, and is silently ignored in GNU nm.
> perhaps the '-e' can simply be removed?

-e came from http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=811627be
I think it was a typo actually as -e was only for HP/UX compat,
and is even ignored now on that platform.

I pushed this gnulib change to fix it, which we'll pick up on next sync:
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=d5e367c5

> The attached patch skips sc-long-lines if needed

pushed.

thanks!
Pádraig




reply via email to

[Prev in Thread] Current Thread [Next in Thread]