[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: deadlock in with fifo reading in tests/dd/no-allocate.sh
|
From: |
Bernhard Voelker |
|
Subject: |
Re: deadlock in with fifo reading in tests/dd/no-allocate.sh |
|
Date: |
Fri, 13 Dec 2013 05:23:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 12/13/2013 02:10 AM, Pádraig Brady wrote:
> Probably a shell bug.
> So what I've done is avoided the shell writing to the fifo.
> Also I've added timeouts to be defensive.
> Also I added a `wait` to avoid overlapping writers to the fifo.
>
> I tested this test passes without delay on GNU/Linux, Solaris and FreeBSD.
>
> The attached should hopefully be the last change before the release.
Sounds sensible. thanks!
The patch looks good:
+1
BTW: out of curiosity, I ran updated misspellings against coreutils,
but it seems we didn't introduce any typos worth changing before 8.22.
Thanks & have a nice day,
Berny