coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic


From: Bernhard Voelker
Subject: Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic
Date: Tue, 03 Dec 2013 00:41:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 12/02/2013 12:59 PM, Pádraig Brady wrote:
> On 12/02/2013 10:53 AM, Bernhard Voelker wrote:
>> -          error (0, errno, _("cannot set permissions of `%s'"),
>> +          error (0, errno, _("cannot set permissions of %s"),
>>                   quote (argv[optind]));
> 
> +1
> 
> This might benefit from a syntax check?
> Something along the lines of: git grep "[\`']%s'" src/*.c

Thanks!

Here's the new patch including a new sc_* rule.

Have a nice day,
Berny

Attachment: 0001-maint-avoid-s-quoting-notation-in-diagnostic-message.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]