coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: avoid perl warning in sc_check-AUTHORS


From: Bernhard Voelker
Subject: [PATCH] maint: avoid perl warning in sc_check-AUTHORS
Date: Thu, 21 Nov 2013 12:15:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On openSUSE-13.1 with perl v5.18.1, I was getting many warnings during
syntax-check:

  check-AUTHORS
  -i used with no filenames on the command line, reading from STDIN.
  -i used with no filenames on the command line, reading from STDIN.
  ...
  -i used with no filenames on the command line, reading from STDIN.
  0.94 check-AUTHORS

The following patch fixes it.

Have a nice day,
Berny

From eb8b45f443380b496d82f1976a7203d6c7828db5 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <address@hidden>
Date: Thu, 21 Nov 2013 12:11:01 +0100
Subject: [PATCH] maint: avoid perl warning in sc_check-AUTHORS

With newer perl, "make syntax-check" issues many warnings like:
  -i used with no filenames on the command line, reading from STDIN.

* cfg.mk (sc_check-AUTHORS): Remove the -i flag in the perl
invocation as it is reading from a pipe.
---
 cfg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cfg.mk b/cfg.mk
index ec91158..788c351 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -181,7 +181,7 @@ sc_check-AUTHORS: $(all_programs)
            exe='[';                                    \
          fi;                                           \
          LC_ALL=$$locale ./src/$$exe --version         \
-           | perl -0 -pi -e 's/,\n/, /gm'              \
+           | perl -0 -p -e 's/,\n/, /gm'               \
            | sed -n -e '/Written by /{ s//'"$$i"': /;'       \
                  -e 's/,* and /, /; s/\.$$//; p; }';   \
        done > $(au_actual) &&                               \
--
1.8.4.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]