[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] base64: improve encoding I/O efficiency
From: |
Bernhard Voelker |
Subject: |
Re: [PATCH] base64: improve encoding I/O efficiency |
Date: |
Mon, 11 Nov 2013 23:13:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Thanks for working on this - the performance gain sounds excellent!
2 minor nits:
On 11/11/2013 06:16 PM, Pádraig Brady wrote:
> [...]
> Also increase the encoding buffer size from 3 to 30KiB.
> This was seen to give a further 8% improvement, taking
> processing time down to 0.235s is the wrapped output case.
did you mean s/is/in/ ?
> diff --git a/NEWS b/NEWS
> index 7028c0d..fafe06d 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -88,6 +88,8 @@ GNU coreutils NEWS -*-
> outline -*-
>
> ** Improvements
>
> + base64 encoding throughtput for bulk data is increased by about 60%.
> +
Typo: s/throughtput/throughput/
Otherwise:
+1
Thanks & have a nice day,
Berny