Re: new snapshot available: coreutils-8.20.119-54cdb0

[Assaf Gordon]

Pádraig Brady wrote, On 02/12/2013 04:18 AM:
> On 02/12/2013 04:45 AM, Assaf Gordon wrote:
>> On Feb 11, 2013, at 20:32, Pádraig Brady <address@hidden> wrote:
>>> On 02/11/2013 08:47 PM, Assaf Gordon wrote:
>>>> +  if (errno != 0 && (errno != EINVAL))
>>>
>>> It might be better to do:
>>>
>>> if (errno == ERANGE)
>>>   error ();
>>>
>>
>> I was thinking about that, my only concern was since we're already dealing 
>> with non-standard code, should we worry about an even weirder implementation 
>> that might return something that's not ERANGE and not EINVAL?
> 
> The error message is just about ERANGE, so it's probably
> best to use just that value in the conditional.
> Reading the docs, EINVAL is the only other possibility.
> 

Attached updated patch.

Thanks!
  -gordon

0001-numfmt-fix-strtol-bug.patch
Description: Text Data