Re: [PATCH] seq cleanup

[Pádraig Brady]

On 12/01/2012 06:55 PM, Dmitry Bogatov wrote:
> Here is simple patch that allow reduce indentation in `print_numbers`
> in `seq.c` by one level to improve readability.
>
> --
> Best regards, Dmitry Bogatov<address@hidden>,
>         GNU Thales maintainer and netiquette guardian.
> GPG: D1E0591E0037BDCCBEE56002788BE01254B7F00D
>
> diff --git a/src/seq.c b/src/seq.c
> index 9c2c51f..01b5927 100644
> --- a/src/seq.c
> +++ b/src/seq.c
> @@ -256,60 +256,61 @@ print_numbers (char const *fmt, struct layout layout,
>   {
>     bool out_of_range = (step < 0 ? first < last : last < first);
>
> -  if (! out_of_range)
> -    {

> +  if (out_of_range)
> +    return;

This seems a bit marginal TBH.
Less indentation is good, but multiple return points is less so.
I'd apply it if it reduced line wrapping, but it doesn't.

thanks,
Pádraig.