[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/17] tests: remove the unused 'root-hint' target
From: |
Stefano Lattarini |
Subject: |
[PATCH 06/17] tests: remove the unused 'root-hint' target |
Date: |
Sun, 2 Sep 2012 21:55:08 +0200 |
* tests/Makefile.am (root-hint): Here. The interested user can see
the reasons why some tests are skipped by looking at the messages
they display on the console; here's an excerpt:
..
PASS: misc/id-groups.sh
id-setgid.sh: skipped test: must be run as root
SKIP: misc/id-setgid.sh
PASS: misc/md5sum.pl
...
PASS: df/total-verify.sh
2g.sh: skipped test: very expensive: disabled by default
SKIP: du/2g.sh
...
Clear enough, and more specific and precise that a generic "some tests
might need to be run as root" message. An if that user is interested
in making those tests run anyway, he'll just take a look to the README
files to look for info. So there's no reason to pollute the stdout
with another "hint" that is subsumed by those messages, and that might
go unnoticed anyway.
Moreover, and possibly more importantly, that hint wasn't being
displayed anyway, even before this change! That's because the
'root-hint' target was listed as prerequisite for the 'check-recursive'
target, which however was not a dependency of the 'check' target in
'tests/Makefile.am' (because that makefile contains no $(SUBDIRS)
definition).
---
tests/Makefile.am | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 1b344f8..1e1f46b 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -162,16 +162,6 @@ all_root_tests = \
check-root:
$(MAKE) check TESTS='$(root_tests)'
-check-recursive: root-hint
-
-# Advertise 'check-root' target.
-.PHONY: root-hint
-root-hint:
- @echo '***********************************************************'
- @echo "NOTICE: Some tests may be run only as root."
- @echo " See the 'Running tests as root' section in README."
- @echo '***********************************************************'
-
EXTRA_DIST += $(all_tests)
# Do not choose a name that is a shell keyword like 'if', or a
--
1.7.12
- [PATCH 00/17] De-recursion for the 'tests' subdirectory., Stefano Lattarini, 2012/09/02
- [PATCH 01/17] build: use 'check-local' to extend the 'check' target, Stefano Lattarini, 2012/09/02
- [PATCH 03/17] maint: remove useless dependency for vc_exe_in_TESTS, Stefano Lattarini, 2012/09/02
- [PATCH 02/17] maint: avoid parsing of Makefile.am from vc_exe_in_TESTS, Stefano Lattarini, 2012/09/02
- [PATCH 04/17] maint: make vc_exe_in_TESTS also work in VPATH builds, Stefano Lattarini, 2012/09/02
- [PATCH 05/17] tests: use suffix, not exec-bit, to tell which files are tests, Stefano Lattarini, 2012/09/02
- [PATCH 06/17] tests: remove the unused 'root-hint' target,
Stefano Lattarini <=
- [PATCH 08/17] maint: remove anachronistic syntax-check, Stefano Lattarini, 2012/09/02
- [PATCH 07/17] maint: remove duplicated declaration of the 'sc_check-AUTHORS' target, Stefano Lattarini, 2012/09/02
- [PATCH 09/17] maint: list of names of built programs available in the Makefiles, Stefano Lattarini, 2012/09/02
- [PATCH 11/17] tests: put test-suite.log back in 'tests/', Stefano Lattarini, 2012/09/02
- [PATCH 12/17] build: remove two now-useless convenience targets, Stefano Lattarini, 2012/09/02
- [PATCH 14/17] maint: avoid a spurious syntax-check error, Stefano Lattarini, 2012/09/02
- [PATCH 13/17] maint: vc_exe_in_TESTS should actually be a syntax check, Stefano Lattarini, 2012/09/02
- [PATCH 15/17] maint: fix syntax checks 'sc_root_tests', Stefano Lattarini, 2012/09/02
- [PATCH 17/17] maint: fix a spurious syntax-check failure, Stefano Lattarini, 2012/09/02
- [PATCH 16/17] tests: more resilient about tainted absolute srcdir path, Stefano Lattarini, 2012/09/02