[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cp preserves mode with --no-preserve=mode
|
From: |
Bernhard Voelker |
|
Subject: |
Re: cp preserves mode with --no-preserve=mode |
|
Date: |
Tue, 07 Aug 2012 17:37:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 |
On 08/07/2012 05:01 PM, Ondrej Oprala wrote:
> Hi, I've renamed the variable to be more hinting of it's purpose
> and --no-preserve=mode should now work properly with directories
> as well.
> Cheers,
> Ondrej
Thanks, that looks good ... maybe the directory case deserves to
be added to the test. Minor nit: the change in copy_internal() is
missing in the commit log.
I'm sure that Padraig/Jim will add both when committing.
BTW: Interestingly, the TODO entry mentioned "--no-preserve=X"
to be buggy:
> -cp --no-preserve=X should not attempt to preserve attribute X
> - reported by Andreas Schwab
but in fact, all the modes (t,o,l,c, and x) but "mode"
have already been working. ;-)
Have a nice day,
Berny