Re: Bug#646022: coreutils: "tail -f" doesn't work with GPFS filesystem

[Martial Bornet (gmail)]

 Thank you very much for your quick answer.
Best regards.

Martial Bornet


Le 20/10/2011 19:19, Jim Meyering a écrit :
> Martial Bornet (gmail) wrote:
>
>> Package: coreutils
>> Version: 8.5-1
>> Severity: normal
>>
>> The "tail" command doesn't know the GPFS filesystem type, so it uses
>> inotify() instead of nanosleep() when used with "-f".
>>
>> The following line should be added to the fs.h file :
>>
>>         # define S_MAGIC_GPFS   0x47504653
>>
>> and the following line should be added to the fremote() function of the
>> tail.c file :
>>
>>         case S_MAGIC_GPFS:
> Thanks for the report.
> Here's the upstream patch.
> We already have the definition of S_MAGIC_GPFS.
>
> >From c07d7486432429eb9e5cadd083d15247b0f4ab0d Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Thu, 20 Oct 2011 19:18:09 +0200
> Subject: [PATCH] tail: with -f, use nanosleep, not inotify on a GPFS file
>  system
>
> * src/tail.c (fremote): List GPFS as a remote file system type.
> * THANKS.in: Update.
> * NEWS (Bug fixes): Mention it.
> Report and suggested change by Martial Bornet in
> http://bugs.debian.org/646022.
> ---
>  NEWS       |    4 ++++
>  THANKS.in  |    1 +
>  src/tail.c |    1 +
>  3 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 3ed44b2..4d210b5 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -7,6 +7,10 @@ GNU coreutils NEWS                                    -*- 
> outline -*-
>    tac no longer fails to handle two or more non-seekable inputs
>    [bug introduced in coreutils-5.3.0]
>
> +  tail -f no longer tries to use inotify on GPFS file systems
> +  [you might say this was introduced in coreutils-7.5, along with inotify
> +   support, but the GPFS magic number wasn't in the usual places then.]
> +
>
>  * Noteworthy changes in release 8.14 (2011-10-12) [stable]
>
> diff --git a/THANKS.in b/THANKS.in
> index 83a7864..b99363b 100644
> --- a/THANKS.in
> +++ b/THANKS.in
> @@ -367,6 +367,7 @@ Mark Melahn                         address@hidden
>  Mark Nudelman                       address@hidden
>  Mark W. Eichin                      address@hidden
>  Markus Demleitner                   address@hidden
> +Martial Bornet                      address@hidden
>  Martin                              address@hidden
>  Martin Buck                         address@hidden
>  Martin Gallant                      address@hidden
> diff --git a/src/tail.c b/src/tail.c
> index f315776..1641a12 100644
> --- a/src/tail.c
> +++ b/src/tail.c
> @@ -904,6 +904,7 @@ fremote (int fd, const char *name)
>          case S_MAGIC_FUSEBLK:
>          case S_MAGIC_FUSECTL:
>          case S_MAGIC_GFS:
> +        case S_MAGIC_GPFS:
>          case S_MAGIC_KAFS:
>          case S_MAGIC_LUSTRE:
>          case S_MAGIC_NCP:
> --
> 1.7.7.419.g87009
>