Re: coreutils-8.13.29-43a9

[Jim Meyering]

Jim Meyering wrote:
...
> Subject: [PATCH] rm: do not resort to stat'ing very long names even on
>  deficient systems
>
> This change affects only uses of rm with -r but without -f and on
> systems lacking support for openat-like functions.
> * src/remove.c (write_protected_non_symlink): Call faccessat
> unconditionally.  Thus we no longer need euidaccess_stat, which was
> the sole function used here to operate on a full relative file name.
> Remove full_name parameter and update caller.
> Other than the removal of the openat_needs_fchdir call, this change
> affects only systems that have neither *at function support nor the
> /proc/self/fd support required to emulate those *at functions.
> * lib/euidaccess-stat.h: Remove file.
> * lib/euidaccess-stat.c: Likewise.
> * m4/euidaccess-stat.m4: Likewise.
> * m4/prereq.m4 (gl_PREREQ): Don't require gl_EUIDACCESS_STAT.
> Prompted by a report from Bruno Haible that the rm/deep-2
> test was failing on HP-UX 11.31.
> See http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1748
> ---
>  lib/euidaccess-stat.c |  134 
> -------------------------------------------------
>  lib/euidaccess-stat.h |    5 --
>  m4/euidaccess-stat.m4 |   11 ----
>  m4/prereq.m4          |    3 +-
>  src/remove.c          |   35 ++-----------
>  5 files changed, 5 insertions(+), 183 deletions(-)
>  delete mode 100644 lib/euidaccess-stat.c
>  delete mode 100644 lib/euidaccess-stat.h
>  delete mode 100644 m4/euidaccess-stat.m4

FYI, that was incomplete (and not yet pushed),
so I added this:

* po/POTFILES.in: Remove lib/euidaccess-stat.c.

diff --git a/po/POTFILES.in b/po/POTFILES.in
index 97bcf45..7301532 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -7,7 +7,6 @@ lib/closein.c
 lib/closeout.c
 lib/copy-acl.c
 lib/error.c
-lib/euidaccess-stat.c
 lib/file-type.c
 lib/gai_strerror.c
 lib/getopt.c