coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use


From: Jim Meyering
Subject: Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]
Date: Mon, 19 Sep 2011 20:09:45 +0200

Bernhard Voelker wrote:
> On 08/24/2011 12:24 PM, Jim Meyering wrote:
>> If you would find some testing-related make shortcut to be useful,
>> please propose a patch, preferably without modifying all tests ;-)
>
> From 4c994ab75a3d0c2eda5aa9246388dccf5058f250 Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <address@hidden>
> Date: Wed, 24 Aug 2011 13:06:28 +0200
> Subject: [PATCH] tests: introduce make targets check-expensive and 
> check-very-expensive
>
> * Makefile.am: add shortcuts to run (very) expensive tests.
> Use "make check-expensive" to run tests with RUN_EXPENSIVE_TESTS=yes,
> use "make check-very-expensive" to run tests with both
> RUN_EXPENSIVE_TESTS=yes and RUN_VERY_EXPENSIVE_TESTS=yes.
> Non-expensive tests are included in all cases.
>
> Signed-off-by: Bernhard Voelker <address@hidden>
> ---
>  Makefile.am |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index f737cf6..556eca5 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -66,6 +66,12 @@ ALL_RECURSIVE_TARGETS += check-root
>  check-root:
>         cd tests && $(MAKE) $@ SUBDIRS=
>
> +# Shortcut tests that are (very) expensive.
> +check-expensive:
> +       $(MAKE) check RUN_EXPENSIVE_TESTS=yes
> +check-very-expensive:
> +       $(MAKE) check-expensive RUN_VERY_EXPENSIVE_TESTS=yes

Thanks.
I've applied this with a little fix: change each sequence
of 8 leading spaces to a TAB.

Oh, and I removed the "Signed-off-by" line.
There is no point in cluttering logs with that.
As "Author," you have obviously signed off on the change.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]