Re: coreutils-8.12.178-df9cd on Solaris 10

[Jim Meyering]

Bruno Haible wrote:
> On Solaris 10 (both SPARC and x86): 1 test failed
>
> FAIL: cp/fail-perm
>
> Find attached the tests/test-suite.log files.

Hi Bruno,

Thanks for yet another test!
Here's the relevant code (what little I can see,
due to that system's broken /bin/sh):

    FAIL: cp/fail-perm (exit: 1)
    ============================
    rm: cannot remove 
`/home/haible/multibuild-1210/solaris10x86-cc/coreutils-8.12.178-df9cd/tests/gt-fail-perm.O36v/DD/D':
 Permission denied
    SKIP: cp/fiemap-empty (exit: 77)


I don't understand what's failing, but will make a guess.
init.sh's remove_tmp_ function is supposed to run this command
  chmod -R u+rwx "$test_dir_"
to ensure that every directory in the hierarchy has rwx permissions.
Could it be that chmod -R is failing to do its job?
Or that somehow remove_tmp_ is not being run?

You can probably find out by rerunning that test with e.g.,

  SHELL=bash make check -C tests TESTS=cp/fail-perm VERBOSE=yes

With a decent shell, we should see far more diagnostics via set -x.

-------
A blind patch (without understanding, always risky),
this might solve the problem:

diff --git a/tests/cp/fail-perm b/tests/cp/fail-perm
index 404c83e..4009c00 100755
--- a/tests/cp/fail-perm
+++ b/tests/cp/fail-perm
@@ -53,6 +53,6 @@ cp --target-directory=symlink F 2> out && fail=1
 sed 's/: The file access permissions.*/: Permission denied/'<out>o1;mv o1 out
 compare out exp || fail=1

-chmod 700 D
+chmod 700 D DD

 Exit $fail