coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] yes.c: do not use exit after error


From: Marek Polacek
Subject: [PATCH] yes.c: do not use exit after error
Date: Fri, 27 May 2011 09:25:11 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3

I think it would be better to exit through the error() and not 
to call the exit() after the error().  This way we can get rid of
one function call (and curly brackets).

* src/yes.c (main): Exit through the error(), remove exit() call
after error().

--- coreutils/src/yes.c.mp      2011-05-27 09:09:56.320233888 +0200
+++ coreutils/src/yes.c 2011-05-27 09:10:29.590237031 +0200
@@ -84,9 +84,6 @@ main (int argc, char **argv)
       for (i = optind; i < argc; i++)
         if (fputs (argv[i], stdout) == EOF
             || putchar (i == argc - 1 ? '\n' : ' ') == EOF)
-          {
-            error (0, errno, _("standard output"));
-            exit (EXIT_FAILURE);
-          }
+          error (EXIT_FAILURE, errno, _("standard output"));
     }
 }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]