coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [coreutils] Re: Builds of coreutils-8.6.19-1369f


From: Jim Meyering
Subject: Re: [coreutils] Re: Builds of coreutils-8.6.19-1369f
Date: Sat, 06 Nov 2010 15:19:05 +0100

Andreas Schwab wrote:

> Jim Meyering <address@hidden> writes:
>
>> Here's a better test case:
>>
>>     $ /bin/sh -c 'f(){ local s=$IFS; test -n "$s"; }; f'
>>     [Exit 1]
>>
>> And based on that, here's a patch to gnulib's tests/init.sh
>> that solves the problem more generally:
>> (but this is not enough for coreutils, since some
>> failing tests don't yet use init.sh)
>
> Why not just add the quotes?  This isn't formally an assignment, so the
> behaviour of the shell is reasonable after all.

Actually, I'm doing both for the upcoming release.
Adding the quotes as a stop-gap measure, because it feels like a
kludge.  I'll remove it once I've converted all tests to use init.sh.
IMHO, the fact that VAR=$OTHER_VAL never needs quotes
should imply that `local VAR=$OTHER_VAL' also requires no quotes.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]