Re: [coreutils] cp/reflink-perm fails on btrfs (and probably on ocfs2, too)

[Jim Meyering]

Pádraig Brady wrote:
> Actually I remember now why we didn't want --reflink
> mutually exclusive with other options.
> It's so it can be used as configuration to change
> the data copy method employed. I.E. it operates
> on much the same level as --sparse in that the
> results are mostly transparent to the user.
> I.E. cp could be aliased like this to minimize
> the amount of space that cp uses:
>
> alias cp='cp --reflink=auto --sparse=always'
>
> So therefore I've changed the patch as per the attached.
> I'll apply in a few hours.
>
>>From 3dc499ba27b1b0b6365179cb6d7bc9e5f6456600 Mon Sep 17 00:00:00 2001
> Subject: [PATCH] cp: make --attributes-only override --reflink completely
>
> * doc/coreutils.texi (cp invocation): Change the description slightly
> so as users might not immediately discount using this option.
> Mention that --reflink is overridden by the other linking options and
> --attributes-only, and give an example where this might be useful.
> * src/copy.c (copy_internal): Bypass the reflink if
> --attributes-only is specifed.
> * tests/cp/reflink-perm: Ensure both --reflink modes are
> overridden by --attributes-only.
> * NEWS: Mention the change in behavior.

Glad you caught that.  Thanks!