coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] [PATCH] maint: avoid a hung 'make syntax-check' in VPATH bui


From: Eric Blake
Subject: [coreutils] [PATCH] maint: avoid a hung 'make syntax-check' in VPATH build
Date: Tue, 10 Aug 2010 11:04:46 -0600

* cfg.mk (sc_system_h_headers): Look for files in correct location.
---

OK to commit?  Without it, 'make syntax-check' hangs on a VPATH
build, since the grep inside $() has no matches, meaning the
grep outside is passed no file names and tries to read stdin.

 cfg.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index dff5de5..ae5f819 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -129,7 +129,7 @@ sc_system_h_headers: .re-list
          trap 'rc=$$?; rm -f .re-list; exit $$rc' 0;                   \
          $(gl_trap_);                                                  \
          grep -nE -f .re-list                                          \
-             $$($(VC_LIST_EXCEPT) | grep '^src/')                      \
+             $$($(VC_LIST_EXCEPT) | grep '^\($(srcdir)/\)\?src/')      \
            && { echo '$(ME): the above are already included via system.h'\
                  1>&2;  exit 1; } || :;                                \
        fi
-- 
1.7.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]