commit-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] GNU Inetutils branch, master, updated. inetutils-1_9_1-56-g4fc1f3


From: Simon Josefsson
Subject: [SCM] GNU Inetutils branch, master, updated. inetutils-1_9_1-56-g4fc1f3e
Date: Wed, 14 Mar 2012 07:42:27 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  4fc1f3e84a05ceba05ebe3a34d69faf3f36389fd (commit)
      from  4c39f0feb06ad4a5dc0a2191b340aaa4b666760f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=4fc1f3e84a05ceba05ebe3a34d69faf3f36389fd


commit 4fc1f3e84a05ceba05ebe3a34d69faf3f36389fd
Author: Simon Josefsson <address@hidden>
Date:   Wed Mar 14 08:42:23 2012 +0100

    tests/dnsdomainname.sh: Don't fail on configuration errors.

diff --git a/ChangeLog b/ChangeLog
index 4f22ce1..6cdd2c9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-14  Simon Josefsson  <address@hidden>
+
+       * tests/dnsdomainname.sh: Don't fail on configuration errors.
+       Suggested by Mats Erik Andersson <address@hidden>.
+
 2012-03-14  Mats Erik Andersson  <address@hidden>
 
        Make explicit dependency on header files for libwrap and termcap.
diff --git a/tests/dnsdomainname.sh b/tests/dnsdomainname.sh
index e30e1e1..4ebc1e7 100755
--- a/tests/dnsdomainname.sh
+++ b/tests/dnsdomainname.sh
@@ -26,13 +26,6 @@ if ! test -x $DNSDOMAINNAME; then
     exit 77
 fi
 
-$DNSDOMAINNAME > /dev/null
-rc=$?
-if test $rc -ne 0; then
-    echo "invoking $DNSDOMAINNAME failed with error code $rc"
-    exit 1
-fi
-
 $DNSDOMAINNAME --version > /dev/null
 rc=$?
 if test $rc -ne 0; then
@@ -47,4 +40,12 @@ if test $rc -ne 0; then
     exit 1
 fi
 
+# FIXME: Don't ignore all errors here.  We want to soft-fail (exit 77)
+# on 1) when getaddrinfo cannot lookup the address at all, or 2) when
+# the canonical address does not contain a period.  Both are
+# configuration issues, and the tool is arguable correct to fail in
+# these situations.  All other errors should lead to hard failures.
+
+$DNSDOMAINNAME || true
+
 exit 0

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog              |    5 +++++
 tests/dnsdomainname.sh |   15 ++++++++-------
 2 files changed, 13 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]