commit-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd] 44/53: mach-defpager: fix warning about uninitialized variable


From: Samuel Thibault
Subject: [hurd] 44/53: mach-defpager: fix warning about uninitialized variable
Date: Thu, 20 Mar 2014 02:23:52 +0000

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch upstream
in repository hurd.

commit 3deb2d7685f9e9b502a992491f747c3a657e4d15
Author: Justus Winter <address@hidden>
Date:   Wed Mar 12 13:10:04 2014 +0100

    mach-defpager: fix warning about uninitialized variable
    
    Previously, failure to look up the given partition was detected after
    the loop by checking whether the loop ran over all existing
    partitions.  Initialize part to NULL and check for that instead.  This
    retains the behavior, but expresses it in a way the compiler
    understands better.
    
    * mach-defpager/default_pager.c (destroy_paging_partition): Initialize
    part to NULL and check for it still being NULL after the loop.
---
 mach-defpager/default_pager.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mach-defpager/default_pager.c b/mach-defpager/default_pager.c
index 33d72b3..1b9d511 100644
--- a/mach-defpager/default_pager.c
+++ b/mach-defpager/default_pager.c
@@ -1991,7 +1991,7 @@ destroy_paging_partition(name, pp_private)
        void **pp_private;
 {
        unsigned int    id = part_id(name);
-       partition_t     part;
+       partition_t     part = NULL;
        boolean_t               all_ok = TRUE;
        default_pager_t         entry;
        int                     pindex;
@@ -2006,7 +2006,7 @@ destroy_paging_partition(name, pp_private)
                part = partition_of(pindex);
                if (part && (part->id == id)) break;
        }
-       if (pindex == all_partitions.n_partitions) {
+       if (! part) {
                pthread_mutex_unlock(&all_partitions.lock);
                return KERN_INVALID_ARGUMENT;
        }

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]