[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: added optional --with-jvm=
From: |
Michael Koch |
Subject: |
Re: added optional --with-jvm= |
Date: |
Mon, 29 Mar 2004 08:10:25 +0200 |
User-agent: |
KMail/1.5.4 |
Am Sonntag, 28. März 2004 21:08 schrieb Etienne Gagnon:
> > I don't object to a --with-vm configure option in principle, it
> > could be useful to build classpath for a specific environment. But
> > I do object to encoding specific knowledge about particular VMs in
> > our tree. We did this in the past and it wasn't a success. (See the
> > kaffe, orp and japhar bits and pieces that have been rotting in the
> > tree because we don't maintain them anymore and/or the vm makers
> > lost interest.)
>
> Mark,
>
> For now, the option simply picks the right default for zipping or not
> the output. This is not *specific VM code*. I do object to your
> objection.
>
> Otherwise, Classpath should simply provide default configuration
> options that work with *all* VMs. So, we should change it to not
> zipping so that it also work with SableVM.
I agree with Mark. You added specific code for SableVM (the defaults for
SableVM). In my opinion the right solution would be to allow the
following for your:
./configure --with-jvm=/some/path/sablevm --datadir=/some/other/path
--libdir=/again/some/other/path. You could easily add this to your
build scripts.
> > Please revert this and discuss the general idea and how it should
> > work on the list first. The argument for the --with-vm option
> > should probably be a directory location or file that comes with the
> > vm
> > sources/installation describing specific optimizations for that
> > environment.
>
> Please look at cvs diff before argumenting on a non-issue.
As I see it, it is non-generic code as it is only for SableVM. We will
have a hard job maintaining it when 100 other VMs want to add their
entries too.
Michael