|
From: | Dalibor Topic |
Subject: | Re: uri patch |
Date: | Thu, 11 Mar 2004 18:52:11 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040218 |
Hi Mark, Mark Wielaard wrote:
Hi,
Thanks. I reformatted a bit and committed as attached. This will help some people greatly thanks. Even though it needs some more work. The class can use some more documentation and I was not completely sure about all the (unimplemented!) private quoteXXX helper methods. Are you sure you need so much different versions? And/Or can the be implemented using URLEncoder?
Maybe. It's been at least a year ago since I really looked at the code, so I can't really tell, atm. URLEncoder may be what we need, though atm I'd say the class needs mauve tests.
cheers, dalibor topic
[Prev in Thread] | Current Thread | [Next in Thread] |