[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] FYI: MetalIconFactory.getRadioButtonMenuItemIcon()
From: |
Tom Tromey |
Subject: |
Re: [cp-patches] FYI: MetalIconFactory.getRadioButtonMenuItemIcon() |
Date: |
Wed, 31 Aug 2005 11:38:41 -0700 |
On Tue, 2005-08-30 at 21:35 +0000, David Gilbert wrote:
> I committed this patch to add an icon for JRadioButtonMenuItems under the
> Metal look
> and feel:
> + public int getIconWidth()
> + {
> + return 10;
> + }
I notice there are an awful lot of constant integers in the plaf code.
My reflex is to say that these ought to be given a name somewhere,
so that we can more easily change them later if need be -- particularly
if we know that, say, many of the "2"s are actually "METAL_BORDER_WIDTH"
or the like, if you catch my meaning. What do you think?
Tom