[cp-patches] Re: Make qt-peers build and run out of the box

[Mark Wielaard]

Hi,

On Tue, 2005-08-23 at 22:04 +0200, Sven de Marothy wrote:
> I'm against this. Not cleaning up whatever problems there are, but you
> do not use the form:
> #include <QtGui/QWidget>
> you use:
> #include <QWidget>

Actually I used #include <Qt/QWidget>.

> And obviously the include paths must be set accordingly.
> Point me to where in Qt's example code they use the former.

The include paths from both a pre-installed (Debian unstable) pkg-config
and from a clean upstream install of 4.0.1 give the following include
paths that require the above #include directives:
$ pkg-config --cflags-only-I QtGui
-I/usr/include/qt4
$ export PKG_CONFIG_PATH=/usr/local/qt4/lib
$ pkg-config --cflags-only-I QtGui
-I/usr/local/qt4/include

The actual Qtgui.pc looks ok:

prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib
includedir=${prefix}/include/qt4

If you think that is wrong maybe there is a bug in the .pc files?
I looked but couldn't find any bug report against this.

I am not against using another convention then required by the
pkg-config files. But that feels wrong since it means we are trying to
second guess the results of pkg-config which was supposed to make our
lives easier. If someone could figure out why pkg-config gives us CFLAGS
that seem unintuitive to some that would be appreciated.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part