Re: [cp-patches] invalidate Label on setText

[Mark Wielaard]

Hi,

On Sat, 2005-08-20 at 23:58 -0400, Thomas Fitzsimmons wrote:
> 2005-08-20  Thomas Fitzsimmons  <address@hidden>
> 
>       * java/awt/Label.java (setText): Invalidate label.


> -  this.text = text;
> -
> -  if (peer != null)
> +  if (this.text != text)
>      {
> -      LabelPeer lp = (LabelPeer) peer;
> -      lp.setText (text);
> +      this.text = text;

This should probably should be

    if ((this.text == null && text != null)
        || (! this.text.equals(text)))

Although invalidating whenever this.text != text probably doesn't hurt.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part