classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: FlowLayout fixlet


From: Roman Kennke
Subject: Re: [cp-patches] FYI: FlowLayout fixlet
Date: Thu, 18 Aug 2005 16:13:32 +0200

> > Roman>    public void setAlignment (int align)
> > Roman>    {
> > Roman> -    if (align != LEFT && align != RIGHT && align != CENTER
> > Roman> -    && align != LEADING && align != TRAILING)
> > Roman> -      throw new IllegalArgumentException ("invalid alignment: " + 
> > align);
> > Roman>      this.align = align;
> > Roman>    }
> >  
> > It would be nice to have a comment here explaining why we don't do
> > the check.
> 
> Ok, I'll add this.

Added.

2005-08-18  Roman Kennke  <address@hidden>

        * java/awt/FlowLayout.java
        (setAlignment): Added comment explaining why we don't check
        for illegal values here.

/Roman

Attachment: FlowLayout.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]